Vecps Code Maintenance: vecps_plotter Rework#387
Conversation
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/tests/summary.txt Build log: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/make_vecpsCodeMaintenance.log |
…eters will now be written in txt-based outputs
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/tests/summary.txt Build log: /work/halld/pull_request_test/halld_sim^vecpsCodeMaintenance/make_vecpsCodeMaintenance.log |
harsimranhs
left a comment
harsimranhs
left a comment
There was a problem hiding this comment.
I, and Edmundo, sat down together. We worked on adapting this code for the two pseudo-scalar system in which it worked (on MC data) with some minor changed to the existing two-pseudo scalar files.
Ultimately, this code works and produces the expected plots.
3 participants
This is a major rework for the vecps_plotter program. The code is now more modular and requires less user modification, reducing the need for recompilation. To highlight some of the most important changes:
-The code now parses the info from the fit file into an "amplitude registry" where all the important info is stored
-The user no longer needs to hard-code the amplitudes to be plotted. Now, every amplitude in the fit file will be plotted
-The code has logic that avoids nonphysical amp and sum combinations that would have produced an empty histogram
-The code now accepts user input that was hard-coded such as: running over a single reaction, plotting acceptance correction histograms, plotting background histograms, and producing only ROOT or txt output
-The code now has a rudimentary CSV output
PS I plan to add two features before merging: adding parameters to the text-based output and a helper function in VecPsPlotGenerator to avoid the need to modify the plotter when adding histograms.